Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct default macro timings, note DT limits #1914

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

caksoylar
Copy link
Contributor

@caksoylar caksoylar commented Sep 2, 2023

Two simple changes: update the wait/tap-ms default values in the macros behavior page which were missed, and add a remark on the limit of number of bindings you can pass (which came up from user questions before, and might come up until #1893 is merged). I tested the bindings limit and saw that it succeeded at 256 items and failed at 257.

@caksoylar caksoylar added documentation Improvements or additions to documentation behaviors labels Sep 2, 2023
@caksoylar caksoylar requested a review from a team September 2, 2023 21:54
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.

@petejohanson petejohanson merged commit b20d317 into zmkfirmware:main Sep 3, 2023
@caksoylar caksoylar deleted the docs/fix-macro-defaults branch September 3, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviors documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants